I have a problem with the actual implementation of TELESCOPE_PIER_SIDE in the emod driver, as it is based on HourAngle-6h it is wrong when you point below the pole.
For example you start guiding on M101 when it rise on the N-E, pier side is wrongly reported as PIER_EAST. A few hours later when it cross the HA limit (east of Polaris) it suddenly change to the right value PIER_WEST, but the scope is really always pointing in the same direction.
I have implemented dec guiding reversal based on pier side in the Phd2 Indi interface but this problem make it dangerous to use.
In the attached proposed patch I change the way to get pier side, no more form HA, but directly from the DEC movement direction (as defined in Ascom), this way the reported value is always right and this fix my problem.
I also add an internal Unknown state to be sure the first read side is reported to the property.
I make basic testing with the eqmod simulator in both Northern and Southern hemisphere and it look good.
Can someone with a better knowledge of the eqmod driver please review this patch ?
My doubt are :
do I get the dec direction at the right place ?
can this change have any side effect at other place in the driver (alignment, limits,...) ?
Patrick
For example you start guiding on M101 when it rise on the N-E, pier side is wrongly reported as PIER_EAST. A few hours later when it cross the HA limit (east of Polaris) it suddenly change to the right value PIER_WEST, but the scope is really always pointing in the same direction.
I have implemented dec guiding reversal based on pier side in the Phd2 Indi interface but this problem make it dangerous to use.
In the attached proposed patch I change the way to get pier side, no more form HA, but directly from the DEC movement direction (as defined in Ascom), this way the reported value is always right and this fix my problem.
I also add an internal Unknown state to be sure the first read side is reported to the property.
I make basic testing with the eqmod simulator in both Northern and Southern hemisphere and it look good.
Can someone with a better knowledge of the eqmod driver please review this patch ?
My doubt are :
do I get the dec direction at the right place ?
can this change have any side effect at other place in the driver (alignment, limits,...) ?
Patrick